Skip to content

adapt to new PGP-contacts #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

adapt to new PGP-contacts #3793

wants to merge 11 commits into from

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Jun 24, 2025 •
edited
Loading

  • hide add-member, qr invite and ability to remove members from email threads/groups
  • show dialog if account migration fails
  • show email icon for unencrypted messages, don't show padlock for encrypted
  • disable ability to edit group for email threads/groups
  • disable chat cloning for email threads/groups
  • show email address in conversation subtitle for email contacts
  • hide "leave group" menu option for email threads/groups
  • don't allow to edit mailinglist name (it will get reset on next incoming message anyways)
  • properly set core submodule when a new core release with Key-contacts chatmail/core#6796 is created

@adbenitez adbenitez requested review from r10s and Hocuri June 24, 2025 15:57
@adbenitez
Copy link
Member Author

in #3507 we removed the email address from subtitle unconditionally because it was displayed for any non-verified contact which included vcard contacts, now that we have a more clearer distinction between email contact and contact with encryption this can be reintroduced and in fact helps to recognize contacts now that all have the same email icon, also because for email usage people expect to see the email address since it is the identity there, this also leverage the situation for email users to have some gains/features instead of worsening with the new pgp-contacts changes:

image

@adbenitez adbenitez mentioned this pull request Jun 24, 2025
Closed
9 tasks
@adbenitez adbenitez self-assigned this Jun 25, 2025
@adbenitez adbenitez added the wait-for-core Issue/PR is waiting for core release label Jun 25, 2025
@github-actions GitHub Actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@github-actions GitHub Actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@Hocuri Hocuri mentioned this pull request Jun 30, 2025
Merged
@github-actions GitHub Actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@Hocuri Hocuri Awaiting requested review from Hocuri

Assignees

@adbenitez adbenitez

Labels
wait-for-core Issue/PR is waiting for core release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adbenitez @r10s