feat: add device message for imported contacts after configuration #6195
Conversation
Add a short info message about how many contacts were added during configuration.
| let mut msg = Message::new_text(format!( | ||
| "Added {} contacts from outgoing chats", | ||
| count | ||
| )); |
There was a problem hiding this comment.
This should probably be a translated message
|
Seems like this crashes some tests because the device message is created at some point after configure when imap gets idle, so tests that rely on message order just get some random message. |
| @@ -802,7 +804,7 @@ impl Imap { | |||
| } | |||
|
|
|||
| info!(context, "Done fetching existing messages."); | |||
| Ok(()) | |||
| Ok(created) | |||
There was a problem hiding this comment.
Can we add the device message right from this function? Otherwise it's strange that the function returns smth very particular, it's about messages, but returns the number of contacts
| async fn add_all_recipients_as_contacts( | ||
| context: &Context, | ||
| session: &mut Session, | ||
| folder: Config, | ||
| ) -> Result<()> { | ||
| ) -> Result<i32> { |
There was a problem hiding this comment.
I'd rather say it should be usize, but at least unsigned.
| } | ||
| Ok(count) => { | ||
| let mut msg = Message::new_text(format!( | ||
| "Added {} contacts from outgoing chats", |
There was a problem hiding this comment.
| "Added {} contacts from outgoing chats", | |
| "Added {} contacts from outgoing messages.", |
It seems we don't have the term "outgoing chat", at least i don't see it in the core code / Delta Chat FAQ.
|
It seems there are only two tests failing, maybe they can be adapted? |
|
I think we still need an irl discussion about how/if we really want this as it is quite a big change for new users |
Add a short device message about how many contacts were added during configuration.
close #3299