fix: Don't emit MsgsNoticed when a message was seen on IMAP #6413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`receive_imf` doesn't emit `MsgsNoticed` on receipt of an IMAP-seen message, so the code was inconsistent. The easiest fix is to not emit `MsgsNoticed` when a message was seen on another device, we don't want to emit `MsgsNoticed` if not all messages are seen, otherwise that removes useful notifications from UIs and may lead to missing messages. Checking that all previous chat messages are at least `InNoticed` looks complicated, let's not do this for now.
iequidoo
force-pushed
the
iequidoo/MsgsNoticed-on-seen-msg
branch
from
bb1eb0b to
8037039
Compare
|
So, this means that notifications will not be removed anymore, even if the chat was opened on the first device? I don't think we should do that. And, even if there is some inconsistency, things are working fine today already; in general, we should only change things if they either make future development easier or make things better for the user. And, while an inconsistency could be confusing to users, I don't think that this specific inconsistency is. It's just too small to spend energy on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
receive_imfdoesn't emitMsgsNoticedon receipt of an IMAP-seen message, so the code was inconsistent. The easiest fix is to not emitMsgsNoticedwhen a message was seen on another device, we don't want to emitMsgsNoticedif not all messages are seen, otherwise that removes useful notifications from UIs and may lead to missing messages. Checking that all previous chat messages are at leastInNoticedlooks complicated, let's not do this for now.EDIT: This is a replacement of #6351.
EDIT: This approach is wrong because we don't have other events that remove notifications for messages seen on other devices, see #6351 (comment) for more info. Closing the PR.