fix: showing wrong chat ("Reply Privately" quote) #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/jumpToMessage-improvements
branch
from
5159c50 to
feae518
Compare
WofWca
force-pushed
the
wofwca/jumpToMessage-improvements
branch
from
feae518 to
6282970
Compare
WofWca
force-pushed
the
wofwca/jumpToMessage-improvements
branch
from
6282970 to
c505c51
Compare
WofWca
force-pushed
the
wofwca/jumpToMessage-improvements
branch
from
c505c51 to
903ca2b
Compare
WofWca
changed the title
WofWca
force-pushed
the
wofwca/jumpToMessage-improvements
branch
from
903ca2b to
d1f8f1c
Compare
nicodh
requested changes
Jan 20, 2025
There was a problem hiding this comment.
When testing I see constantly the (new) error log:
Tried to show messages from a different chat.
this.accountId === 1, this.chatId === 13, target IDs: 1, 14. jumpToMessageId === 81
I see that the correct group chat ID is fetched from backend (14) for the correct msgId from the quote (81), but when jump_to_message is performed still the chatId of the private chat is in this.chatId
Edit: this happens even before clicking the "jump down" button
Also add a runtime warning. The `MessageListStore` re-creation logic was apparently introduced in cf9eb1f.
1. "Reply Privately" to a message in a group. 2. Click on the quote. This will open the original chat. 3. Click the "jump down" button. This will load the messages from the private chat, but still show the original group chat in the chat header.
WofWca
force-pushed
the
wofwca/jumpToMessage-improvements
branch
from
d1f8f1c to
36584ff
Compare
|
Right, I rebased on top of #4510, and the error is no longer printed for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will load the messages from the private chat,
but still show the original group chat in the chat header.