-
-
Notifications
You must be signed in to change notification settings - Fork 69
blog post about the browser edition #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out the page preview at https://staging.delta.chat/1120/en/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about mentioning the security of this? And perhaps that people shouldn't try to deploy this in production?
There is password protection, but it's not particularly securely implemented, as far as I can tell (I'm not a security expert though):
It's just a string equality check, with no timeouts and no timing attack protection.
Also, the WebSocket server doesn't perform origin validation IIRC.
Otherwise, at a glance the post looks short and nice, but I haven't read it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, Simon!
A couple of short and one longer modification suggestion for the ending of the post.
General review note: Never start a new paragraph and use "this" or "it". It's better if each paragraph can be read on its own without remembering prior ones.
consistent capitalization: "s/delta chat/Delta Chat" and "s/desktop/Desktop" and "s/electron/Electron/" and "s/tauri/Tauri/"
Feel free to merge any suggestion and then modify afterwards to your likening. Discussing each suggestion in depth would cumbersome and latency-prone. I'll do another review afterward your merging/next draft.
Co-authored-by: holger krekel <[email protected]>
_posts/2025-05-20-browser-edition.md
Outdated
See the [Web version topic in the Delta Chat Forum](https://support.delta.chat/t/what-would-be-needed-for-a-standalone-web-version-without-a-server-component/3789) for further discussion. | ||
|
||
If you are not really into programming, it might be hard to understand how hard these issues are. | ||
But no worries, even if you are a programmer, or even with ourselves as matter experts, it's hard to predict :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sentence is a bit hard to read, we should simplify it somehow.
Co-authored-by: holger krekel <[email protected]>
I'll see to add a hint to that.
AFAIK it checks for the session token, which may be enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright overall.
If you say you're about to merge it, I could add some spelling corrections in a separate MR.
Correct, unify proper nouns' spelling.
correct spelling in "Browser edition" post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Blog post that talks a bit about the browser edition.
Ideally it can become what we link to if someone asks for a browser edition again.
I'm looking forward to your improvements ideas and suggestions.