Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse telephone numbers #52

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Nov 2, 2023

  • basic parsing
  • more testing
  • document format in spec.md
  • integrate element into text parsing
  • add test for phone numbers in text
  • add test for phone numbers in desktop set & markdown

closes #3

we can take googles library for reference: https://github.com/google/libphonenumber, it is used by telegram iOS, signal desktop and probably also android os

@nicodh nicodh changed the base branch from master to main March 26, 2025 21:45
@nicodh nicodh deleted the branch main March 26, 2025 21:50
@nicodh nicodh closed this Mar 26, 2025
@nicodh nicodh reopened this Mar 26, 2025
@farooqkz
Copy link
Collaborator

farooqkz commented Apr 8, 2025

I think maybe close it as it's too old? Also as an additional note, as I refactored link parsing, make small changes to its code for accepting tel: links.

@nicodh
Copy link
Member

nicodh commented Apr 8, 2025

I think maybe close it as it's too old? Also as an additional note, as I refactored link parsing, make small changes to its code for accepting tel: links.

Yes if you think it's worthless now close it

@Simon-Laux
Copy link
Member Author

I think this is still needed to get to a point where message-parser can also be used on mobile. just supporting tel: is not enough for that.

@r10s
Copy link
Member

r10s commented Apr 8, 2025

the future is hard to predict, so better optimise for the present :)

so, it seems fine concentrate on things needed by desktop today, this is obviously hard enough.

if we then decide at some point, as everything else fine, to use message-parser on mobile, it seems easy to add phone number support then

@farooqkz
Copy link
Collaborator

farooqkz commented Apr 8, 2025

the future is hard to predict, so better optimise for the present :)

so, it seems fine concentrate on things needed by desktop today, this is obviously hard enough.

if we then decide at some point, as everything else fine, to use message-parser on mobile, it seems easy to add phone number support then

Maybe but I would still vote to have tel: links. People could use it on Desktop to dial it on their phone using something like KDE Connect.

@farooqkz
Copy link
Collaborator

farooqkz commented Apr 8, 2025

If we have plans for using MP on mobile, I think it's a good idea to finish this and use it. Create a roadmap/project and include this there. If not, I'm in favor of closing it.

@r10s
Copy link
Member

r10s commented Apr 8, 2025

today, there are no concrete plans to use MP on mobile.

priorities today are multi-transport, calls, channels, stability (just from mind, we do not have nor want a roadmap with times, things manifest in working code, not promises :)

@Simon-Laux
Copy link
Member Author

Maybe but I would still vote to have tel: links

they are already linkified by the message parser. we could add them to the allow list in desktop, so that they open directly, but that would be a desktop issue and is off topic for this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement parsing of telephone numbers
4 participants