-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse telephone numbers #52
base: main
Are you sure you want to change the base?
Conversation
& format document
also add element type to wasm bindings and demo
I think maybe close it as it's too old? Also as an additional note, as I refactored link parsing, make small changes to its code for accepting |
Yes if you think it's worthless now close it |
I think this is still needed to get to a point where message-parser can also be used on mobile. just supporting |
the future is hard to predict, so better optimise for the present :) so, it seems fine concentrate on things needed by desktop today, this is obviously hard enough. if we then decide at some point, as everything else fine, to use message-parser on mobile, it seems easy to add phone number support then |
Maybe but I would still vote to have |
If we have plans for using MP on mobile, I think it's a good idea to finish this and use it. Create a roadmap/project and include this there. If not, I'm in favor of closing it. |
today, there are no concrete plans to use MP on mobile. priorities today are multi-transport, calls, channels, stability (just from mind, we do not have nor want a roadmap with times, things manifest in working code, not promises :) |
they are already linkified by the message parser. we could add them to the allow list in desktop, so that they open directly, but that would be a desktop issue and is off topic for this pr. |
closes #3
we can take googles library for reference: https://github.com/google/libphonenumber, it is used by telegram iOS, signal desktop and probably also android os