Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Prevent usage of twisted>=24 #468

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mhertz
Copy link
Contributor

@mhertz mhertz commented Oct 28, 2024

Breaking ability of adding multiple torrents at once in WebUI, with following error in web-console after pressing 'Add':

deluge-all.js:7 Uncaught TypeError: Cannot read properties of undefined (reading 'filename')
    at S.getFilename (deluge-all.js:7:1946)
    at S.<anonymous> (deluge-all.js:3:2013)
    at Ext.util.MixedCollection.each (ext-all.js:21:111850)
    at constructor.each (ext-all.js:21:321534)
    at S.onAddClick (deluge-all.js:3:1932)
    at S.onClick (ext-all.js:21:426947)
    at HTMLTableElement.I (ext-all.js:21:57750)

The issue stems from only one of the torrents getting uploaded to server, after cgi.parse_multipart was removed from twisted.web.http and replaced with stdlib's email.message, in there commit 4579398.

Avoids breaking ability of adding multiple torrents at once in WebUI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant