-
Notifications
You must be signed in to change notification settings - Fork 1.8k
reco: fetch alerts #40182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reco: fetch alerts #40182
Conversation
Enhance incident fetching logic to include a 1-second buffer for the last occurred timestamp. This ensures accurate tracking of incident occurrences in the next run. Updated datetime import to include timedelta for this functionality.
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed. |
Hi @GalNakash-RecoLabs, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GalNakash-RecoLabs
for your contribution!
please see the validation errors
feel free to reach me here in case of any help you need/
- Bump current version to 1.6.0 in pack_metadata.json. - Update Docker image to demisto/python3:3.12.8.3296088 in Reco.yml. - Add release notes for version 1.6.0, including changes to last run logic and Docker image update.
- Adjusted formatting in `Reco_test.py` for better readability. - Updated docstring in `get_alert_ai_summary` method for consistency. - Simplified function definition formatting in `enrich_incident` method.
No errors anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution!
Co-authored-by: Israel Lappe <[email protected]>
10685bc
into
demisto:contrib/RecoLabs_reco-incidents
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
* reco: fetch alerts Enhance incident fetching logic to include a 1-second buffer for the last occurred timestamp. This ensures accurate tracking of incident occurrences in the next run. Updated datetime import to include timedelta for this functionality. * Update Reco pack to version 1.6.0 - Bump current version to 1.6.0 in pack_metadata.json. - Update Docker image to demisto/python3:3.12.8.3296088 in Reco.yml. - Add release notes for version 1.6.0, including changes to last run logic and Docker image update. * Refactor Reco test and client methods for consistency - Adjusted formatting in `Reco_test.py` for better readability. - Updated docstring in `get_alert_ai_summary` method for consistency. - Simplified function definition formatting in `enrich_incident` method. * Update Packs/Reco/ReleaseNotes/1_6_0.md --------- Co-authored-by: GalNakash-RecoLabs <[email protected]> Co-authored-by: Israel Lappe <[email protected]>
Enhance incident fetching logic to include a 1-second buffer for the last occurred timestamp. This ensures accurate tracking of incident occurrences in the next run. Updated datetime import to include timedelta for this functionality.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have