Skip to content

reco: fetch alerts #40182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GalNakash-RecoLabs
Copy link
Contributor

Enhance incident fetching logic to include a 1-second buffer for the last occurred timestamp. This ensures accurate tracking of incident occurrences in the next run. Updated datetime import to include timedelta for this functionality.

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Enhance incident fetching logic to include a 1-second buffer for the last occurred timestamp. This ensures accurate tracking of incident occurrences in the next run. Updated datetime import to include timedelta for this functionality.
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jun 4, 2025
@content-bot content-bot changed the base branch from master to contrib/RecoLabs_reco-incidents June 4, 2025 13:55
@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Jun 4, 2025
@content-bot content-bot requested a review from ilappe June 4, 2025 13:56
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ilappe will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @GalNakash-RecoLabs, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GalNakash-RecoLabs
for your contribution!
please see the validation errors
feel free to reach me here in case of any help you need/

- Bump current version to 1.6.0 in pack_metadata.json.
- Update Docker image to demisto/python3:3.12.8.3296088 in Reco.yml.
- Add release notes for version 1.6.0, including changes to last run logic and Docker image update.
- Adjusted formatting in `Reco_test.py` for better readability.
- Updated docstring in `get_alert_ai_summary` method for consistency.
- Simplified function definition formatting in `enrich_incident` method.
@GalNakash-RecoLabs
Copy link
Contributor Author

Thanks @GalNakash-RecoLabs for your contribution! please see the validation errors feel free to reach me here in case of any help you need/

No errors anymore

@ilappe ilappe self-requested a review June 8, 2025 10:24
Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution!

@ilappe ilappe merged commit 10685bc into demisto:contrib/RecoLabs_reco-incidents Jun 9, 2025
17 of 18 checks passed
@content-bot content-bot mentioned this pull request Jun 9, 2025
5 tasks
Copy link

github-actions bot commented Jun 9, 2025

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

ilappe added a commit that referenced this pull request Jun 10, 2025
* reco: fetch alerts

Enhance incident fetching logic to include a 1-second buffer for the last occurred timestamp. This ensures accurate tracking of incident occurrences in the next run. Updated datetime import to include timedelta for this functionality.

* Update Reco pack to version 1.6.0

- Bump current version to 1.6.0 in pack_metadata.json.
- Update Docker image to demisto/python3:3.12.8.3296088 in Reco.yml.
- Add release notes for version 1.6.0, including changes to last run logic and Docker image update.

* Refactor Reco test and client methods for consistency

- Adjusted formatting in `Reco_test.py` for better readability.
- Updated docstring in `get_alert_ai_summary` method for consistency.
- Simplified function definition formatting in `enrich_incident` method.

* Update Packs/Reco/ReleaseNotes/1_6_0.md



---------

Co-authored-by: GalNakash-RecoLabs <[email protected]>
Co-authored-by: Israel Lappe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants