Skip to content

Cyberint Takedown feature #40428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 60 commits into from
Jul 13, 2025
Merged

Cyberint Takedown feature #40428

merged 60 commits into from
Jul 13, 2025

Conversation

klevitskiy
Copy link
Contributor

@klevitskiy klevitskiy commented Jul 1, 2025 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation
Screen.Recording.2025-07-01.at.14.47.42_s.mp4

klevitskiy and others added 30 commits May 21, 2025 09:18
@klevitskiy
add draft takedown
5b54f0a
@klevitskiy
add draft takedown
38cab24
@klevitskiy
add draft takedown
122ccc0
@klevitskiy
fix td module
6442f17
@klevitskiy
fix docs
74471d4
@klevitskiy
fix docs
d0069ee
@klevitskiy
fix code
4213bda
@klevitskiy
fix code
03e4857
@klevitskiy
fix test module
82fbea7
@klevitskiy
add test
cac3de4
@klevitskiy
add test
74b5cbe
@klevitskiy
add test
ce6d108
@chkp-jkohn
takedown test suite
3314159
@chkp-jkohn
takedown test suite
ec4a362
@klevitskiy
minor fixes
35fffbd
@chkp-jkohn
merge kirill changes
5f641c1
@chkp-jkohn
test file changes
4ef5312
@chkp-jkohn
WIP - tests
438e634
@chkp-jkohn
WIP - tests
c732d2d
@klevitskiy
fix tests
aa04d6f
@klevitskiy
fix tests
202fa88
@klevitskiy
add tests
b46d9a6
@klevitskiy
fix test_module
a6249c7
@klevitskiy
fix retrieve_takedown_requests command
830234d
@klevitskiy
INTGR-127 Add new subtypes to XSOAR filter
d0ec708
@klevitskiy
add request options for submit TD
b2328d7
@klevitskiy
fix request options for submit TD
b2d89e4
@klevitskiy
fix request options for request TD
ddcde87
@klevitskiy
fix request options for request TD
7fe8549
@klevitskiy
fix request options for request TD
fea13c0
@klevitskiy
Copy link
Contributor Author

klevitskiy commented Jul 7, 2025 •
edited
Loading

Everything else looks good. Just make sure to remove the edits to pyproject.toml as that is a repo-wide file that shouldn't be touched here. Once thats done we can proceed

Thanks :)

@itssapir You are perfectly right! My bad, I reverted the pyproject.toml edits.

@MLainer1 MLainer1 removed their request for review July 8, 2025 12:06
itssapir
itssapir approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@itssapir itssapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Nice

@itssapir itssapir added docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jul 9, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4108310

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 9, 2025
@itssapir itssapir added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 9, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4112368

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 9, 2025
itssapir
itssapir requested changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@itssapir itssapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @klevitskiy,
Sorry for adding another comment after marking with Approved, there were a couple minor errors on the internal pipeline:

Secrets were found in the following files:
In File: Packs/Cyberint/Integrations/Cyberint/Cyberint.yml:22
Secret found: https://your-company.cyberint.io/
In File: Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.yml:14
Secret found: https://your-company.cyberint.io/
In File: Packs/Cyberint/Integrations/TakedownCyberint/command_examples.txt:2
Secret found: https://dummy-url-for-takedown.com/

You can simply add these urls to the pack's secrets ignore file.
Please also merge the latest changes from master, these should hopefully solve the rest of the issues I see.

@klevitskiy
Copy link
Contributor Author

Hi @klevitskiy, Sorry for adding another comment after marking with Approved, there were a couple minor errors on the internal pipeline:

Secrets were found in the following files:
In File: Packs/Cyberint/Integrations/Cyberint/Cyberint.yml:22
Secret found: https://your-company.cyberint.io/
In File: Packs/Cyberint/Integrations/FeedCyberint/FeedCyberint.yml:14
Secret found: https://your-company.cyberint.io/
In File: Packs/Cyberint/Integrations/TakedownCyberint/command_examples.txt:2
Secret found: https://dummy-url-for-takedown.com/

You can simply add these urls to the pack's secrets ignore file. Please also merge the latest changes from master, these should hopefully solve the rest of the issues I see.

@itssapir Hi, it's added :)

@itssapir itssapir added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 9, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4113669

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 9, 2025
@itssapir itssapir merged commit 30c17ce into demisto:contrib/CyberInt_takedown-feature Jul 13, 2025
22 checks passed
@content-bot content-bot mentioned this pull request Jul 13, 2025
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

itssapir added a commit that referenced this pull request Jul 13, 2025
@content-bot @klevitskiy
@chkp-jkohn @itssapir
Cyberint Takedown feature (#40428) (#40584)
cca6dd7 
* add draft takedown

* add draft takedown

* add draft takedown

* fix td module

* fix docs

* fix docs

* fix code

* fix code

* fix test module

* add test

* add test

* add test

* takedown test suite

* takedown test suite

* minor fixes

* test file changes

* WIP - tests

* WIP - tests

* fix tests

* fix tests

* add tests

* fix test_module

* fix retrieve_takedown_requests command

* INTGR-127 Add new subtypes to XSOAR filter

* add request options for submit TD

* fix request options for submit TD

* fix request options for request TD

* fix request options for request TD

* fix request options for request TD

* fix request options for request TD

* fix request options for request TD

* bump version

* update documentation

* fix warnings

* fix warnings

* fix warnings

* update docker image version

* fix tests

* fix test

* fix marketplaces

* update docker image to 3.12

* update release notes

* fix release notes

* fix release notes

* fix md

* fix warnings

* fix test

* fix test resources

* fix commented lines

* revert changes

* add secret

---------

Co-authored-by: klevitskiy <[email protected]>
Co-authored-by: Joel <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itssapir itssapir itssapir approved these changes

Assignees

@DeanArbel DeanArbel

@itssapir itssapir

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@klevitskiy @CLAassistant @content-bot @itssapir @DeanArbel @MLainer1 @chkp-jkohn