Initial FAQ #9
Open
Initial FAQ #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't resolve the warnings in this codebase, because (presumably) underlying libs are also referring to React.PropTypes
Removes ALMOST ALL THE THINGS from the default project
|
Also don't be afraid of the huge diff size, the vast majority of it is yarn.lock which you can ignore. |
bwreilly
approved these changes
May 30, 2017
|
|
||
|
|
||
| const FAQs = (props, { collection }) => { | ||
| const faqs = enhanceCollection(collection, { |
There was a problem hiding this comment.
| }; | ||
|
|
||
| FAQs.contextTypes = { | ||
| collection: PropTypes.array.isRequired, |
There was a problem hiding this comment.
So, in favor of PropTypes for this thing rather than doing a bunch of work trying to make it TypeScript or just going with nothing?
|
|
||
| const PagesList = ({ pages }) => ( | ||
| <div> | ||
| {pages.length ? |
There was a problem hiding this comment.
Ternary operator is gross as heck but I'm not sure what parts of this you wrote.
| white: '#fff', | ||
| grey: { | ||
| darkest: '#454545', | ||
| darker: '#666', |
|
Honestly this all seems reasonable - but why this over the other react one we were looking at? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built with Phenomic, which is based on React/redux. It was pretty simple to put together, the majority of the time I spent was yanking out a ton of unnecessary stuff