Fix typescript issues #1619
Merged
Fix typescript issues #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2025 17:46
Signed-off-by: Manuel Ruck <[email protected]>
Signed-off-by: Manuel Ruck <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses various TypeScript issues by refactoring type definitions, updating the ESLint configuration for code consistency, and removing unused imports. Key changes include updates in ESLint ignore patterns, refactored types from Slide to SlideProps across multiple files, and adjustments to navigation handling and import cleanup.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .eslintrc.js | Updated ESLint config with additional ignore patterns |
| src/types/navigation.ts | Changed TypedRoutes from an interface to a type alias for AppRoutes |
| src/screens/WahlOMeter/Bundestag/index.tsx | Updated navigation to use an object with pathname and params |
| src/screens/Introduction/utils/getSlides.ts | Refactored to use SlideProps and standardized double quotes |
| src/screens/Introduction/components/data/index.ts | Updated type definitions to use SlideProps with consistent quoting |
| src/app/(sidebar)/_layout.tsx | Removed unused import and related code |
| src/screens/Search/Results.tsx | Removed unused imports from react-navigation and native-stack components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes across multiple files to improve code consistency, update dependencies, and refactor code. The most significant changes include updates to ESLint configuration, removal of unused imports, and refactoring of type definitions.
Code Consistency and Configuration:
.eslintrc.js: Updated ESLint configuration to include additional ignore patterns for generated files andnode_modulesdirectory.Code Refactoring:
src/screens/Introduction/components/data/index.ts: Changed the type ofScreenDatafromSlidetoSlidePropsand updated string literals to use double quotes for consistency.src/screens/Introduction/utils/getSlides.ts: Updated import statements and changed the return type fromSlide[]toSlideProps[].Removal of Unused Imports:
src/app/(sidebar)/_layout.tsx: Removed unused importuseDevModeStoreand related code. [1] [2]src/screens/Search/Results.tsx: Removed unused imports fromreact-navigation.Navigation Update:
src/screens/WahlOMeter/Bundestag/index.tsx: Updated navigation to use object withpathnameandparamsfor routing.Type Definition Update:
src/types/navigation.ts: ChangedTypedRoutesfrom an interface to a type alias forAppRoutes.