feat: add linting workflow for code quality checks #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces changes to the GitHub workflows to improve CI reliability and integrate code quality checks. The key changes include:
- Removal of the pull request trigger in the E2E tests workflow to run tests only on pushes.
- Addition of a new linting workflow that sets up Node.js, caches Yarn dependencies, and runs both ESLint and TypeScript checks.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/lint.yaml | New workflow for running linting and TypeScript checks |
| .github/workflows/e2e-tests.yaml | Removed the pull_request trigger to limit test execution |
Comments suppressed due to low confidence (2)
.github/workflows/lint.yaml:1
- [nitpick] Using multiple emojis in the workflow name may reduce readability in CI logs; consider simplifying the name to 'Code Quality Checks' for clarity.
name: ✨ Code Quality Checks ✅
.github/workflows/lint.yaml:24
- [nitpick] Ensure that using Node.js version '22' is intentional and aligns with project requirements, since it may be ahead of the typical LTS release cycle.
node-version: "22"
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Manuel Ruck <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new GitHub workflow for linting and TypeScript checks to improve overall code quality, while also limiting the E2E tests workflow to run only on pushes to the main branch.
- Added .github/workflows/lint.yaml for code quality checks via ESLint and TypeScript.
- Removed the pull_request trigger from .github/workflows/e2e-tests.yaml to restrict E2E tests to push events.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/lint.yaml | New workflow for linting and TypeScript checks. |
| .github/workflows/e2e-tests.yaml | Removal of pull_request trigger to limit test runs on push events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the GitHub workflows for end-to-end tests and code quality checks. The most important changes are the removal of the pull request trigger from the E2E tests workflow and the addition of a new workflow for code linting and TypeScript checks.
Changes to GitHub workflows:
.github/workflows/e2e-tests.yaml: Removed thepull_requesttrigger to ensure E2E tests only run on pushes to the main branch..github/workflows/lint.yaml: Added a new workflow for code quality checks, including steps for checking out the repository, setting up Node.js, caching Yarn dependencies, installing dependencies, running ESLint, and running TypeScript checks.