Fix PDF document loading stuck at 0% by adding proper error handling #1665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PDF documents were getting stuck showing "0% loaded" indefinitely instead of displaying error messages when they failed to load. This issue was particularly affecting Android users, where error messages were being ignored rather than shown to users, leaving them wondering if the app was broken.
Root Cause
The
PdfScreencomponent only set the PDF source URI but didn't implement any error handling callbacks provided by thereact-native-pdflibrary. When PDF loading failed (due to network issues, invalid URLs, or server errors), the component would remain in an indefinite loading state without user feedback.Solution
Added comprehensive error handling and loading state management to the PDF viewer:
Error Handling:
onErrorcallback to capture PDF loading failuresLoading Progress:
onLoadProgresscallback to show actual loading percentages (0-100%)State Management:
PdfStateinterface to track loading, error, progress, and success statesUser Experience Improvements
Before:
After:
Technical Details
The implementation follows existing app patterns:
Button,ActivityIndicator)Testing
This fix addresses the core issue where PDF loading errors were silently ignored, providing users with clear feedback and retry options when documents fail to load.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.