Fix/header button styles #1668
Merged
Fix/header button styles #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds iOS compatibility support for legacy iPads and removes verbose TypeScript logging from VSCode settings.
- Adds
UIDesignRequiresCompatibility: trueto iOSinfoPlistconfiguration to enable backward compatibility with legacy iPad designs - Removes the
typescript.tsserver.log: "verbose"setting from VSCode configuration, which was likely used for debugging
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app.config.ts | Adds UIDesignRequiresCompatibility flag to iOS infoPlist and restructures the configuration to properly spread conditional NSAppTransportSecurity settings |
| .vscode/settings.json | Removes verbose TypeScript server logging setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes minor configuration adjustments to improve iOS compatibility and clarify development settings. The most notable changes are in the iOS app configuration, where a new compatibility key is added to the
infoPlist, and a small cleanup is made to the VSCode settings.iOS app configuration improvements:
UIDesignRequiresCompatibility: trueto theinfoPlistinapp.config.tsto ensure compatibility with certain iOS design requirements.infoPlistto always include the compatibility key and only addNSAppTransportSecuritysettings in non-CI environments.Development environment cleanup:
"typescript.tsserver.log": "verbose"setting from.vscode/settings.jsonto reduce unnecessary logging during development.