Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update newick definition to be more in-line with my interpretation of the newick standard #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update newick definition to be more in-line with my interpretation of the newick standard #173

wants to merge 1 commit into from

Conversation

tommy-mor
Copy link

@keflavich
Copy link
Contributor

This is a fairly major change and should be accompanied with some documentation, and perhaps tests. Also... this can't be the only place the Newick format is used, is it?

@tommy-mor
Copy link
Author

Agreed. I am looking into it and just documenting my process here

@tommy-mor
Copy link
Author

Also just posting this to see what other people think. Do you agree something seems fishy here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommy-mor @keflavich