Fixed #7 #16
Open
Fixed #7 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadaa
reviewed
May 28, 2017
src/components/Canvas.js
Outdated
| } | ||
| getPosition(event) { | ||
| if (event.clientX) { | ||
| if (typeof event.clientX === 'number') { |
There was a problem hiding this comment.
src ディレクトリ以下の修正は、テストとは関係ないので、別の issue を立てて治したいです。
test/actions/changeWidthTest.js
Outdated
| const width = 40; | ||
| expect(action(width)).to.deep.equal({ | ||
| type: CHANGE_WIDTH, | ||
| width |
There was a problem hiding this comment.
ごめん。このあたりも、lineWidth で統一しておきましょうか。
同様に、changeWidth も changeLineWidth にしておきたいです。
別の issue で直しましょう。
| @@ -0,0 +1,12 @@ | |||
| import action from 'actions/changeColor'; | |||
There was a problem hiding this comment.
テストは各モジュールの unit test というより、ユーザのアクションベースでやっていって良いような気がします。
たとえば、changeColor のテストだと、Pallet 上の "red" パネルをクリック and タッチする。というユーザのアクションを与えて、結果的に、きちんと Canvas の color が変わっていることをチェックしていけば良いかと思います。
DevTools のテストはこんな感じです。
https://github.com/devtools-html/debugger.html/tree/master/src/test/mochitest
There was a problem hiding this comment.
@dadaa そうなんですね
となると、unit test はいらなくなるでしょうか。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.