Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix np.unique() calls for numpy 2.0 #27

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Jun 30, 2024

Numpy now returns a 2D array for reverse indexing, but we want the flattened version.

fixes #26

Numpy now returns a 2D array for reverse indexing, but we want
the flattened version.
@dengwirda
Copy link
Owner

Thanks @xylar, confirmed that both python 3.12 + numpy 2.0 as well as python 3.10 + numpy 1.26 are happy with this.

@dengwirda dengwirda merged commit 5729a38 into dengwirda:master Jul 1, 2024
3 checks passed
@xylar xylar deleted the fix-bisect-for-numpy-2.0 branch July 1, 2024 06:24
@xylar
Copy link
Contributor Author

xylar commented Jul 1, 2024

@dengwirda, thanks for reviewing and merging this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy 2.0 compatibility
2 participants