Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out all mssql defined data types into a mssqltypes subpackage #518

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

yukiwongky
Copy link
Contributor

Part of issue #357

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #518 into master will decrease coverage by 0.17%.
The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   68.67%   68.49%   -0.18%     
==========================================
  Files          22       20       -2     
  Lines        5056     4984      -72     
==========================================
- Hits         3472     3414      -58     
+ Misses       1379     1367      -12     
+ Partials      205      203       -2
Impacted Files Coverage Δ
mssql.go 81.59% <0%> (ø) ⬆️
mssql_go19.go 95.65% <100%> (ø) ⬆️
buf.go 100% <100%> (ø) ⬆️
types.go 77.29% <16.66%> (ø) ⬆️
bulkcopy.go 57.74% <44.44%> (ø) ⬆️
token.go 55.91% <7.54%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fca52...1844e83. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #518 into master will decrease coverage by 0.13%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   68.86%   68.72%   -0.14%     
==========================================
  Files          22       20       -2     
  Lines        5058     5004      -54     
==========================================
- Hits         3483     3439      -44     
+ Misses       1369     1361       -8     
+ Partials      206      204       -2
Impacted Files Coverage Δ
error.go 75% <ø> (ø) ⬆️
mssql_go19.go 95.65% <100%> (ø) ⬆️
types.go 77.29% <100%> (ø) ⬆️
bulkcopy.go 57.74% <44.44%> (ø) ⬆️
mssql_go19pre.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbb681...c0df4eb. Read the comment docs.

@yukiwongky
Copy link
Contributor Author

I've pulled Error out from this PR. @denisenkom can you check?

@denisenkom
Copy link
Owner

This needs to be rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants