-
-
Notifications
You must be signed in to change notification settings - Fork 23
Update codebase #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codebase #154
Conversation
Actually the ci I also needs some work, I updated it, but I'll need to test it first so I'll mark this as draft |
I tested and fixed the ci it should work now, also I noticed that the libraries are not stripped, I think they should be for example the linux x86_64 one goes from 8.9mb to 1.mb If you agree I can also add that to the ci |
Actually I just remembered that now there is |
Hi - sorry the development slowed down a bit as I got busy with other projects and work. I'll get back to this PR soon as I find some time. I had looked into node:sqlite, and the performance isn't on par with the FFI library afaik. Will have to run benchmarks to be sure. |
I agree with stripping the libraries, we should do that. For now this PR is good, I'll merge it so we have the bare minimum updates on main for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, I really appreciate it
No problem thanks as well , its a nice library and the bench idea is really cool |
I updated just before you merge its just missing a deno fmt run to fix the ci issue |
Oh I just realized haha, thought I was tripping. Thanks for the update, will format it |
whats missing is updating benchmarks, seems some are outdated like wasm sqlite