refactor(quic): introduce endpoint, 0rtt, cleanup #27444
Conversation
devsnek
force-pushed
the
quic-changes
branch
from
a408558 to
a6ec5b6
Compare
devsnek
changed the title
devsnek
force-pushed
the
quic-changes
branch
2 times, most recently
from
c69a4d6 to
cf6128e
Compare
| ); | ||
| let getEndpointResource; | ||
|
|
||
| function transportOptions({ |
There was a problem hiding this comment.
I don't understand the purpose of this function...
There was a problem hiding this comment.
just pulls out transport options from the larger options bag to reduce serde overhead going into rust
ext/net/03_quic.js
Outdated
| class QuicEndpoint { | ||
| #endpoint; | ||
|
|
||
| constructor({ hostname = "::", port = 0, rid } = { __proto__: null }) { |
There was a problem hiding this comment.
Is this a public API? If so we shouldn't expose rid here. Maybe add another function that requires an internal symbol to construct endpoint from an existing resource id?
There was a problem hiding this comment.
How about rewriting this API to use object wrap/cppgc?
There was a problem hiding this comment.
Looks like it already uses cppgc, any chance we could further reduce amount of JS? Or maybe we could make this module lazy loaded similar to WebGPU code?
There was a problem hiding this comment.
updated to use lazy loading
| * const caCert = await Deno.readTextFile("./certs/my_custom_root_CA.pem"); | ||
| * const conn1 = await Deno.connectQuic({ hostname: "example.com", port: 443, alpnProtocols: ["h3"] }); | ||
| * const conn2 = await Deno.connectQuic({ caCerts: [caCert], hostname: "example.com", port: 443, alpnProtocols: ["h3"] }); | ||
| * ``` |
There was a problem hiding this comment.
Sigh, we should really address #16160 so it wraps lines
A QUIC endpoint is a UDP socket which multiplexes QUIC sessions, which may be initiated in either direction. This PR exposes endpoints and moves things around as needed. Now that endpoints can be reused between client connections, we have a way to share tls tickets between them and allow 0rtt. This interface currently works by conditionally returning a promise. Also cleaned up the rust op names, fixed some lingering problems in the data transmission, and switched to explicit error types.
A QUIC endpoint is a UDP socket which multiplexes QUIC sessions, which may be initiated in either direction. This PR exposes endpoints and moves things around as needed.
Now that endpoints can be reused between client connections, we have a way to share tls tickets between them and allow 0rtt. This interface currently works by conditionally returning a promise.
Also cleaned up the rust op names, fixed some lingering problems in the data transmission, and switched to explicit error types.