Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unstable): don't error on non-existing attrs or type attr #27456

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marvinhagemeister
Copy link
Contributor

When running selectors for JS linting plugins we would error when encountering an unknown attribute name:

// selector
Foo[non-existant]

// error
Error: Missing string id: <number>

This was caused by using 0 as the invalid marker, but also overloading 0 with an actual node type. So the fix is to reserve 0 as the invalid marker and move the property type to the next index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant