fix(ext/http): improve error message when underlying resource of request body unavailable #27463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st body unavailable
bartlomieju
approved these changes
Jan 2, 2025
| undefined, | ||
| (controller, error) => { | ||
| if (ObjectPrototypeIsPrototypeOf(BadResourcePrototype, error)) { | ||
| // TODO(kt3k): We would like to pass `error` as `cause` when BadResource supports it. |
Member
There was a problem hiding this comment.
Hm, shouldn't this be doable already?
Member
Author
There was a problem hiding this comment.
Doesn't look so as they are implemented like:
class BadResource extends Error {
constructor(msg) {
super(msg);
this.name = "BadResource";
}
}
Member
Author
There was a problem hiding this comment.
Created an issue in deno_core denoland/deno_core#1031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error message when reading request body in
Deno.serveand the underlying resource is unavailable.The error message is currently
Bad Resource ID. This PR change it toCannot read request body as underlying resource unavailablecloses #27133