Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace actions/checkout@v3 with actions/checkout@v4 #330

Merged
merged 3 commits into from
Oct 25, 2024
Merged

refactor: Replace actions/checkout@v3 with actions/checkout@v4 #330

merged 3 commits into from
Oct 25, 2024

Conversation

katayama8000
Copy link
Contributor

@katayama8000 katayama8000 commented Oct 13, 2024 •
edited
Loading

I just replaced actions/checkout@v3 with actions/checkout@v4.

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magurotuna
Copy link
Member

Thanks for catching this. Of course this change looks totally good, but another issue is happening where deployctl's dependency depends on Deno.isatty which was removed from Deno v2.0. I'll try to fix this first and then will merge your PR.

@katayama8000 katayama8000 changed the title Replace actions/checkout@v3 -> actions/checkout@v4 Replace actions/checkout@v3 -> actions/checkout@v4 Oct 16, 2024
@katayama8000 katayama8000 changed the title Replace actions/checkout@v3 -> actions/checkout@v4 Replace actions/checkout@v3 with actions/checkout@v4 Oct 16, 2024
@katayama8000
Copy link
Contributor Author

katayama8000 commented Oct 16, 2024 •
edited
Loading

@magurotuna
Thanks :)

@katayama8000 katayama8000 changed the title Replace actions/checkout@v3 with actions/checkout@v4 refactor: Replace actions/checkout@v3 with actions/checkout@v4 Oct 16, 2024
magurotuna
magurotuna approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@magurotuna magurotuna merged commit 468aa65 into denoland:main Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magurotuna magurotuna magurotuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katayama8000 @CLAassistant @magurotuna