Skip to content

Fix CI caching recommendation #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 16, 2025
Merged

Fix CI caching recommendation #1698

merged 13 commits into from
May 16, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 12, 2025

The previous recommendation was problematic because it put the DENO_DIR in the cwd, which would cause the files inside it to be auto-discovered.

Trying to find a recommendation that works... env.HOME doesn't

Edit: Landed denoland/setup-deno#89 and waiting on denoland/setup-deno#98 in order to recommend just using that.

@dsherret dsherret marked this pull request as draft May 12, 2025 14:56
@dsherret dsherret marked this pull request as ready for review May 15, 2025 21:40
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philhawksworth philhawksworth merged commit 1c6e5de into main May 16, 2025
4 checks passed
@dsherret dsherret deleted the fix_ci_recommendation branch May 21, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants