Skip to content

fix: switch back to package.json as it's necessary for GH actions #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025

Conversation

dsherret
Copy link
Member

#95 used a deno.json, but we need a package.json for managing the version and publishing the action.

@dsherret dsherret requested a review from lucacasonato as a code owner May 14, 2025 17:08
@dsherret dsherret requested a review from crowlKats May 14, 2025 17:30
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit ee64dd3 into main May 14, 2025
37 checks passed
@csvn
Copy link
Contributor

csvn commented May 14, 2025

Ah, did not realize package.json was required for the action, sorry! 😅

@dsherret dsherret deleted the fix_switch_package_json branch May 15, 2025 03:05
@dsherret
Copy link
Member Author

dsherret commented May 15, 2025

It's no problem. Neither did I 😄

@dsherret
Copy link
Member Author

@crowlKats actually, I kind of feel like it's not necessary. Isn't the version just based on the tag?

@crowlKats
Copy link
Member

@dsherret so it isnt just about version, but also author & description. but i looked into it, and noticed that these are actually defined via an action.yml file, so yes, it seems we dont need to use pafckage.json afterall. not sure why we were using versions and descriptions in the first place there then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants