-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add "lts" version option #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implement the "lts" version option for Deno setup. * **action.yml** - Add "lts" as a valid option for the `deno-version` input. * **README.md** - Add usage example for the "lts" version option. * **src/version.mjs** - Add logic to handle the "lts" version option in `parseVersionRange` function. - Add `resolveLTS` function to fetch the latest lts version. - Update `resolveVersion` function to handle "lts" version option. * **.github/workflows/test.yml** - Add a test for the "lts" version option. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/denoland/setup-deno?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the "lts" option to the Deno setup action by extending version parsing and resolution logic, updating configuration files, and adding relevant tests.
- Update JSDoc typedefs and version range parsing in src/version.mjs
- Introduce a new resolveLTS function and extend install logic for the "lts" channel
- Update action description, README example, and tests to include the new option
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/version.mjs | Added "lts" support in version parsing and resolution with a new resolveLTS function |
src/install.mjs | Added a corresponding case for "lts" in installation process |
action.yml | Updated input description to include "lts" option |
README.md | Added usage example for the "lts" option |
.github/workflows/test.yml | Added test case for the "lts" option |
(cherry picked from commit a1496dd)
Implement the "lts" version option for Deno setup.
action.yml
deno-version
input.README.md
src/version.mjs
parseVersionRange
function.resolveLTS
function to fetch the latest lts version.resolveVersion
function to handle "lts" version option..github/workflows/test.yml
For more details, open the Copilot Workspace session.