Skip to content

refactor(yaml): remove throwError() method #6593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

timreichen
Copy link
Contributor

This PR removes the throwError() and throws errors directly. This makes the code easier to read.

@timreichen timreichen requested a review from kt3k as a code owner April 16, 2025 06:18
@github-actions github-actions bot added the yaml label Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 59.18367% with 20 lines in your changes missing coverage. Please review.

Project coverage is 94.58%. Comparing base (3a021b2) to head (9145f7a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
yaml/_loader_state.ts 59.18% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6593      +/-   ##
==========================================
- Coverage   94.58%   94.58%   -0.01%     
==========================================
  Files         579      579              
  Lines       43752    43749       -3     
  Branches     6494     6494              
==========================================
- Hits        41381    41378       -3     
  Misses       2331     2331              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the code easier to read.

Agree.

LGTM

@kt3k kt3k merged commit 96efffc into denoland:main Apr 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants