-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gitleaks): add initial support for gitleaks #4589
base: master
Are you sure you want to change the base?
Conversation
Here are some preliminary results... Shell:ALEInfoExpand
Terraform:ALEInfoExpand
|
Closes dense-analysis#4588 feat(gitleaks): add gitleaks linter for sh fix(gitleaks): set lint_file for gitleaks feat(gitleaks): add gitleaks support for multiple file-types fix: add docs and support a few more filetypes docs: add gitleaks docs tests: add gitleaks handler & linter tests docs(gitleaks): add missing docs docs: fix toc & heading sorting docs: fix toc issue
e1b1e6a
to
aba76d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add gitleaks
to the default list of linters for various filetypes. I think we can add it where we have a List defined for any of these filetypes. It's defined in the linter.vim file and there are tests for each of the filetypes.
@@ -0,0 +1,37 @@ | |||
Before: | |||
call ale#assert#SetUpLinterTest('tex', 'gitleaks') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add in a test case with the supported filetypes in a List where we check if the linter is set up for all of the filetypes we need in a loop. We can write one filetype per line. Calling the tear down and set up functions in a loop will probably work.
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Closes #4588
TODO: