Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification | Trigger for Action Needed Email #97108

Open
14 tasks
steele-lm opened this issue Nov 13, 2024 · 0 comments
Open
14 tasks

Verification | Trigger for Action Needed Email #97108

steele-lm opened this issue Nov 13, 2024 · 0 comments
Labels
backend Dependency Verification New integration for updating diary entries dependents-benefits engineering Engineering topics

Comments

@steele-lm
Copy link
Contributor

Issue Description

For any async job where we've accepted the payload from the vets-website... if we've called an async job, meaning one that we aren't notifying the veteran of a failure, we need to do the following:

  1. Log it.

You can use this lib/zero_silent_failures/monitor.rb to help you do the logging.
Here are examples of usage: https://github.com/department-of-veterans-affairs/vets-api/pull/18941/files

  1. Send an email
    a. We should be able to get the VA-notify template ID's from Fiorella.

Also, here is some documentation that may help:
https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/maste[…]tform/practices/zero-silent-failures/logging-silent-failures.md

Resources


Tasks

  • - Building on the research and workflows from the mural, use the logging library to log the failure.
  • -
  • Test notification by logging into staging with a test user, updating the profile ID to something that sends to you
  • Determine alerting and error handling if email fails to deliver
  • Implement new statsd metric. See this write up.
  • Update form flow diagram to include action needed email

Acceptance Criteria

  • A notification trigger that sends an email to the address the claimant entered in the form when: (if no address is entered into the form, use their VA profile email)
    • Claim fails to establish through backup pathway (open question on how long to wait for success)
    • Evidence fails to upload (immediately)
    • Evidence fails to upload (days later) (open question on how long to wait for success)
  • Logging and monitoring for failed sends
  • New statsd metric implemented
  • Form flow updated to include action needed email
  • Turn on flipper in production
@steele-lm steele-lm added 686 Label for any work associated with Dependency Claims using VA Form 21-686c backend dependents-benefits engineering Engineering topics zero-silent-failures Work related to eliminating silent failures ZSF:Email For work to send an email to veterans/beneficiaries that a silent failure has occurred labels Nov 13, 2024
@steele-lm steele-lm added Dependency Verification New integration for updating diary entries and removed 686 Label for any work associated with Dependency Claims using VA Form 21-686c zero-silent-failures Work related to eliminating silent failures ZSF:Email For work to send an email to veterans/beneficiaries that a silent failure has occurred labels Nov 13, 2024
@steele-lm steele-lm changed the title Copy of 686 | Trigger for Action Needed Email Verification | Trigger for Action Needed Email Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Dependency Verification New integration for updating diary entries dependents-benefits engineering Engineering topics
Projects
None yet
Development

No branches or pull requests

3 participants