93214: Fix error logging for DR SavedClaim status updater jobs

[dfong-adh]

Summary

This fixes an erroneous log message for non-error evidence statuses in the DR SavedClaim status updater jobs.

Related issue(s)

department-of-veterans-affairs/va.gov-team#93214
department-of-veterans-affairs/va.gov-team#90103
#18579

Testing done

Tested locally and spec tests

• New code is covered by unit tests

What areas of the site does it impact?

This impacts Rails logs and the SavedClaim status updater jobs.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[LindseySaari]

It seems like the conditional is different here where logging is happening upon error status whereas before in the unless condition, it was happening when the status was not ERROR_STATUS. Is this the intent, just want to check?

[dfong-adh]

That's correct - we want it to log only if the status changed to ERROR_STATUS but not if it was already ERROR_STATUS.

[anniebtran]

changes look good 👍 one question just for clarification — are we still incrementing when non-error statuses are unchanged? 🤔 i might have missed it in the code, but seems like we might also want to more broadly check that we only increment when statuses change?

[dfong-adh]

changes look good 👍 one question just for clarification — are we still incrementing when non-error statuses are unchanged? 🤔 i might have missed it in the code, but seems like we might also want to more broadly check that we only increment when statuses change?

For now we are incrementing for every non-error status check. I think it is a good idea to change it so we are incrementing statsd values only when the status values change, but I'd prefer to make that a separate ticket + PR.

[github-actions]

Backend-review-group approval confirmed.