Update dependencies for GCC 15 #12442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
force-pushed
the
jamiemagee/gcc-15
branch
3 times, most recently
from
1e715ce to
f1efa4a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
common/lib/dependabot/pull_request_creator/message_builder/link_and_mention_sanitizer.rb
Fixed
Show fixed
Hide fixed
JamieMagee
force-pushed
the
jamiemagee/gcc-15
branch
from
cfb75e0 to
6311912
Compare
JamieMagee
commented
Jun 13, 2025
| @@ -1290,30 +1290,30 @@ def commits_details(base:, head:) | |||
| expect(pr_message).to eq( | |||
| "Bumps [business](https://github.com/gocardless/business) from `2468a02` to `cff701b`.\n" \ | |||
| "# Commits\n\n" \ | |||
| " - [`26f4887`](https://github.com/gocardless/business/commit/" \ | |||
There was a problem hiding this comment.
The indentation changes below are intentional. See kivikakk/comrak#135
| mode = unsafe ? :UNSAFE : :DEFAULT | ||
| return doc.to_commonmark([mode] + render_options) unless format_html | ||
| render_options = COMMONMARKER_OPTIONS.dup | ||
| render_options[:hardbreaks] = false if text.match?(MARKDOWN_REGEX) |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
|
I opened an issue upstream with commonmarker with the odd link parsing behavior: gjtorikian/commonmarker#376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
GCC 15 released in April 20251 and is starting to make its way into Linux distributions. Some of the Ruby gems that we depend on have native dependencies that require local compilation, and those dependencies need to be update to work with GCC 15. They are:
commonmarkergoogle-protobufAnything you want to highlight for special attention from reviewers?
Here is an example of a compilation failure that occurs when trying to compile the current version of the
commonmarkerdependency with GCC 15.NOTE:
gpgmestill does not work with GCC 15How will you know you've accomplished your goal?
Checklist
Footnotes
https://gcc.gnu.org/gcc-15/ ↩