Add more Sorbet types #12490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

randhircs merged 51 commits into main from dev/rybrande/SorbetTypes

Jul 3, 2025

Contributor

ryanbrandenburg commented Jun 20, 2025

What are you trying to accomplish?

Adding more Sorbet types to easy Ruby development.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

I have run the complete test suite to ensure all tests and linters pass.
I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
I have written clear and descriptive commit messages.
I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
I have ensured that the code is well-documented and easy to understand.

ryanbrandenburg requested review from a team as code owners

June 20, 2025 16:50

github-actions bot added L: java:gradle L: dotnet:nuget L: python labels

github-advanced-security bot found potential problems

View reviewed changes

python/lib/dependabot/python/package/package_registry_finder.rb Fixed Show fixed Hide fixed

JamieMagee reviewed

View reviewed changes

gradle/lib/dependabot/gradle/file_parser.rb Outdated Show resolved Hide resolved

JamieMagee reviewed

View reviewed changes

gradle/lib/dependabot/gradle/file_parser.rb Outdated Show resolved Hide resolved

JamieMagee reviewed

View reviewed changes

gradle/lib/dependabot/gradle/file_parser/property_value_finder.rb Show resolved Hide resolved

JamieMagee reviewed

View reviewed changes

gradle/lib/dependabot/gradle/file_parser/repositories_finder.rb Outdated Show resolved Hide resolved

JamieMagee reviewed

View reviewed changes

gradle/lib/dependabot/gradle/file_parser/repositories_finder.rb Outdated Show resolved Hide resolved

JamieMagee reviewed

View reviewed changes

gradle/lib/dependabot/gradle/file_parser/repositories_finder.rb Outdated Show resolved Hide resolved

JamieMagee reviewed

View reviewed changes

nuget/spec/spec_helper.rb Outdated

Member

JamieMagee Jun 24, 2025

Everything under spec is ignored from Sorbet 😅 Sorbet + RSpec doesn't work 😭

JamieMagee previously approved these changes

View reviewed changes

Member

JamieMagee commented Jun 24, 2025

These are pretty major changes. We'll need to monitor telemetry once this is deployed for InformationalError

ryanbrandenburg dismissed JamieMagee’s stale review via

2f5391f

June 24, 2025 18:38

JamieMagee previously approved these changes

View reviewed changes

randhircs reviewed

View reviewed changes

Contributor

randhircs left a comment

Please check if we can further remove untyped.

gradle/lib/dependabot/gradle/file_parser.rb Outdated Show resolved Hide resolved

python/lib/dependabot/python/requirement.rb Outdated Show resolved Hide resolved

python/lib/dependabot/python/requirement.rb Outdated Show resolved Hide resolved

ryanbrandenburg dismissed JamieMagee’s stale review via

e466716

July 2, 2025 18:04

Contributor Author

ryanbrandenburg commented Jul 2, 2025

@randhircs updated based on your comments. The submit-nuget failure seems unrelated to my change since it's failing for everyone.

ryanbrandenburg requested review from randhircs and JamieMagee

July 2, 2025 20:22

Member

JamieMagee commented Jul 2, 2025

@randhircs updated based on your comments. The submit-nuget failure seems unrelated to my change since it's failing for everyone.

Created #12546 to track this

randhircs approved these changes

View reviewed changes

Contributor

randhircs left a comment

Thank you for your recheck, I approve.

ryanbrandenburg added 6 commits

July 3, 2025 16:38


          Type gradle/file_parser

9bfa39e


          Cleanup

790101a


          Sorbet types for update_checker

b864a18


          Sorbet on version

bd3a977


          Sorbet for repositories_finder

a1c9adf


          multi_dependency_updater Sorbet

8f8ae0a

ryanbrandenburg added 25 commits

July 3, 2025 16:38


          Cleanup

110101c


          Revert file_fetcher

192175c


          Sorbet pip_version_resolver

5bbbe7f


          Continue

cea2cb6


          Fix test

96486fa


          Continue

b4ebb1a


          Continue

f23649f


          Continue

15f8e2e


          Sorbet python version

e4019dc


          Sorbet python version

a9db3c5


          Sorbet pip version resolver

71f5a73


          Sorbet pip version resolver

60b4045


          Sorbet nilable

bf1c564


          Sorbet nilable

821784e


          Cleanup

251753e


          Cleanup

7a4b164


          Fix tests

7e0afed


          Fix tests

8fedd09


          PR fixes

2c4e6a4


          PR cleanup


          Remove useless spec changes

725a8dd


          Cleanup the cleanup

c5f3eec


          Type cleanup

4f7918c


          Fix expectations

2420d27


          Fix types

5ada332

randhircs force-pushed the dev/rybrande/SorbetTypes branch from b07b2a7 to 5ada332 Compare

July 3, 2025 20:38

randhircs merged commit aee6ba1 into main

109 of 111 checks passed

randhircs deleted the dev/rybrande/SorbetTypes branch

July 3, 2025 21:01

LionZXY mentioned this pull request

Dependabot fails -> gradle: Passed nil into T.must #12558

Closed

1 task

markhallen mentioned this pull request

Fix gems-bump-version workflow by removing sorbet-runtime #12590

Merged

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: dotnet:nuget L: java:gradle L: python