-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Initial rust_toolchain
updater
#12492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2c6e7e5
to
e7dc6ed
Compare
5dab76e
to
3a6409a
Compare
requirement_string = obj.to_s.strip | ||
|
||
# Parse requirement strings with operators (e.g., ">= 1.72.0") | ||
match = requirement_string.match(/^(>=|>|<=|<|=)\s?(.+)$/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other ecosystems I've seen 'bump' syntax operator ~>
that essentially allows only the last listed number to change. E>g., ~>1.72.0
would allow an update to 1.72.5
but not to 1.73.0
. Similarly, ~>1.72
would allow an update to 1.75
but not to 2.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what cases though? rust-toolchain.toml
expects an exact version, not a range. I only implemented this to support ignore-conditions
in Dependabot configuration.
b7d4e15
to
b4204ff
Compare
What are you trying to accomplish?
Add support for updating rust toolchain versions1.
Supports both
rust-toolchain.toml
andrust-toolchain
.Currently supported toolchain specifications:
1.88.0
,1.88
)nightly-2025-06-20
,beta-2025-05-12
,stable-2025-05-15
)Currently unsupported toolchain specifications:
1.88.0-beta.5
)1.88.0-x86_64-unknown-linux-gnu
)See
JamieMagee/dependabot-rust-toolchain
for examples.Anything you want to highlight for special attention from reviewers?
Related:
rust-toolchain
support cli#463rust_toolchain
smoke tests smoke-tests#302rust-toolchain
ecosystem support github/dependabot-action#1504How will you know you've accomplished your goal?
Checklist
Footnotes
https://rust-lang.github.io/rustup/concepts/toolchains.html ↩