Skip to content

Remove source from Ignore Conditions #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Mar 3, 2025

PR Description:

This PR removes the source field from ignore conditions to ensure consistent dependency filtering across updates.

Why?

  • source in ignore conditions is not required for proper filtering.
  • Removing source makes ignore conditions more effective and universally applied across different ecosystems.
  • Simplifies configuration and avoids potential mismatches in dependency updates.

Example Change:

Before (With source)

ignore-conditions:
  - dependency-name: get-intrinsic
    source: tests/smoke.yaml
    version-requirement: '>1.0.3'

After (Without source)

ignore-conditions:
  - dependency-name: get-intrinsic
    version-requirement: '>1.0.3'

Expected Impact:

✅ Ensure dependencies listed in ignore-conditions are properly ignored without dependency on source.
✅ Reduce unnecessary configuration complexity.

@kbukum1 kbukum1 requested a review from a team as a code owner March 3, 2025 22:09
@kbukum1 kbukum1 force-pushed the kamil/remove-sources-for-ignore-conditions branch from 6153958 to dece4cb Compare March 3, 2025 23:35
@kbukum1
Copy link
Contributor Author

kbukum1 commented Jul 9, 2025

Need to revisit if necessary.

@kbukum1 kbukum1 closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant