This repository was archived by the owner on Jan 28, 2024. It is now read-only.
refactor: hashSet을 위한 equals, hashCode 메소드 오버라이딩 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaesung
suggested changes
Feb 8, 2021
junhaesung
reviewed
Feb 18, 2021
domain/src/main/java/com/depromeet/team5/domain/store/AppearanceDay.java
Show resolved
Hide resolved
junhaesung
suggested changes
Mar 2, 2021
interfaces/src/test/java/com/depromeet/team5/unit/StoreJpaTest.java
Outdated
Show resolved
Hide resolved
| // then | ||
| Set<DayOfWeek> updatedAppearanceDays = updatedStore.getAppearanceDays().stream().map(AppearanceDay::getDay).collect(Collectors.toSet()); | ||
| Set<PaymentMethodType> updatedPaymentMethods = updatedStore.getPaymentMethods().stream().map(PaymentMethod::getMethod).collect(Collectors.toSet()); | ||
| assertThat(updatedAppearanceDays).isEqualTo(Set.of(DayOfWeek.MONDAY, DayOfWeek.THURSDAY)); |
There was a problem hiding this comment.
월, 목요일에서 월, 금요일로 변경하는 경우, AppearanceDay 객체들이 어떻게 저장되는지도 확인해주세요.
현재 코드로 보면 월, 목 2개 삭제 후 다시 월, 금에 해당되는 2개의 AppearanceDay 를 생성할 것 같은데요
목요일만 삭제하고, 금요일만 추가할 수 있다면 그렇게 수정하면 좋을 것 같습니다.
There was a problem hiding this comment.
이건 고민을 해봤는데 updateStore 메소드 내부적으로 hash set 을 비운 후에 데이터를 넣는 식으로 구현되어 있어서 문제가 되지 않을 것 같아 그대로 두었습니다!
There was a problem hiding this comment.
hash set 을 비우고 데이터를 넣는 식으로 구현된 이유는 그 때 아래 링크와 같은 상황이 발생해서였습니다!
https://blog.leocat.kr/notes/2016/04/26/hibernate-no-longer-reference
interfaces/src/test/java/com/depromeet/team5/unit/StoreJpaTest.java
Outdated
Show resolved
Hide resolved
interfaces/src/test/java/com/depromeet/team5/unit/StoreJpaTest.java
Outdated
Show resolved
Hide resolved
interfaces/src/test/java/com/depromeet/team5/unit/StoreJpaTest.java
Outdated
Show resolved
Hide resolved
- private 메소드 아래로 이동 - update 후 다시 데이터 조회하여 검증하도록 수정 - 각 테스트의 이름을 좀 더 구체적으로 수정
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.