Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

[WIP]Updated the seed file to reflect new text per issue #342, have to che… #369

Conversation

rich-allen-gov
Copy link
Contributor

I've updated the seed file, will also need to provide a migration to actually update the data.

Checklist

I have…

  • run the application locally (bin/rails server) and verified that my changes behave as expected.
  • run static code analysis (bin/rubocop) and vulnerability scan (bin/brakeman) against my changes.
  • run the test suite (bin/rake spec) and verified that all tests pass.
  • summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
  • thoroughly outlined below the steps necessary to test my changes.
  • attached screenshots illustrating relevant behavior before and after my changes.
  • read, understand, and agree to the terms described in CONTRIBUTING.md.
  • added my name, email address, and copyright date to CONTRIBUTORS.md.

Summary of Changes

#342

Testing

[WIP] Will provide screenshots. Automated testing will be passing.

Screenshots

Attach relevant before and after screenshots here.

… have to check if there will be deployment steps since there is seed data here
@jgarber623-gov
Copy link
Contributor

I've updated the seed file, will also need to provide a migration to actually update the data.

@rich-allen-gov Based on the… unique… way we're handling seed data (documented on this wiki page), you shouldn't have to worry about a migration.

☝️ Note the caveats on that wiki page about how we're using seed data versus how it's supposed to be used.

@rich-allen-gov
Copy link
Contributor Author

Gotcha, thanks saved some effort there! I'll just go ahead and get the screenshots and package this up for review.

@rich-allen-gov
Copy link
Contributor Author

For now I will close this, and create new pr with my branch that I pushed direct to the repo.

I went ahead and created #372 which should fix this going forward if we can merge it in.

@rich-allen-gov rich-allen-gov deleted the content/342/create-shipment-slide14 branch March 13, 2018 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants