feat: Github workflow for a11y issues benchmarking

[manojvenkatap]

This GitHub workflow fetches accessibility tickets based on defined SLAs. If a ticket breaches the SLA, labels are added to track and prioritize issues for easier resolution.

[thuey]

You may want to define this code in a separate bash script (e.g. label_a11y_issues.sh) instead of inline. It would probably be easier to maintain that way

[manojvenkatap]

This one i am not sure how to do this? could you please help me

[thuey]

What I'm suggesting is you:

1. Create a file called label_a11y_issues.sh
2. Make it executable (e.g. chmod +x label_a11y_issues.sh
3. Move everything that's in the run block into the file and add a #!/bin/bash to the top of the file. Example:

#!/bin/bash

set -e
....

4. Update this to just run the script: run: ./label_a11y_issues.sh

[thuey]

You don't have to do this now, but maybe a future enhancement would be to make these values configurable via inputs

[manojvenkatap]

will do this later one after running some successful runs

[thuey]

Can you please add a README.md, describing how this action is to be used? Check out the other action in this repo for an example.

[thuey]

@manojvenkatap This comment still needs to be addressed

[manojvenkatap]

added readme.md, but i am not confident that the example provided will work or not because i have not tested. please suggest if any changes needed

[thuey]

You should be able to test it by following the instructions you provided in a test repo. You'll just point at the latest commit hash in this branch instead of main

[thuey]

What I'm suggesting is you:

1. Create a file called label_a11y_issues.sh
2. Make it executable (e.g. chmod +x label_a11y_issues.sh
3. Move everything that's in the run block into the file and add a #!/bin/bash to the top of the file. Example:

#!/bin/bash

set -e
....

4. Update this to just run the script: run: ./label_a11y_issues.sh

[thuey]

Mostly smaller things now

[thuey]

@manojvenkatap This comment still needs to be addressed

[thuey]

Do we need/want the *? If we do any kind of loose checking, it seems like it should be to not be case sensitive. Something like:

Suggested change

	if [[ "$LABELS" == *"$level"* ]]; then
	if [[ "${LABELS,,}" == "${level,,}" ]]; then

[manojvenkatap]

Provided suggestion is matching if LABELS exactly equals Blocker, Critical, etc, But GitHub issues usually have multiple labels, and LABELS is like "A11y, VPAT, Serious", so LABELS != Serious exactly. so i changed to if echo "$LABELS" | grep -iq "$level"; then

[thuey]

I see, I misread this before. However, your example is still problematic if there is a label that contains one of these words (e.g. "very serious" or something).

A better approach would be to do something like this:

if echo "$issue" | jq -e '.labels[].name | ascii_downcase | select(. == (\"$level\" | ascii_downcase))' > /dev/null; then

This uses jq to find if the label is in the list of labels by checking each label, rather than doing a string search against a concatenated string, which is potentially error prone

[thuey]

Same as above. Consider doing this:

Suggested change

	if [[ "$LABELS" == *"$sla_label"* ]]; then
	if [[ "${LABELS,,}" == "${sla_label,,}" ]]; then

[thuey]

See updated suggestion

[thuey]

the PR title should match our semantic commit convention: https://github.com/dequelabs/dev-process/blob/f981ec903da4f3f700b0d2af89014af84041e84b/git/README.md#commit-message-sections

[thuey]

You should be able to test it by following the instructions you provided in a test repo. You'll just point at the latest commit hash in this branch instead of main

[thuey]

I see, I misread this before. However, your example is still problematic if there is a label that contains one of these words (e.g. "very serious" or something).

A better approach would be to do something like this:

if echo "$issue" | jq -e '.labels[].name | ascii_downcase | select(. == (\"$level\" | ascii_downcase))' > /dev/null; then

This uses jq to find if the label is in the list of labels by checking each label, rather than doing a string search against a concatenated string, which is potentially error prone

[thuey]

See updated suggestion

[thuey]

I think this is good enough that we can start using it. But in a follow-up PR, can you please:

1. Add unit tests for a11y-sla.sh
2. Add shellcheck

I can help you get this set up if you want to schedule a pairing session

[thuey]

nit: Since this file is only used in actions/a11y-sla-breach-labels, it would be best to collocate it there

[manojvenkatap]

can we do this in next PR?