Skip to content

add dialog to remove active PortForwards from a Pod #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kandros
Copy link
Contributor

@kandros kandros commented Jul 31, 2021

Co-authored-by: ludovico russo [email protected]

usecase: Often I'm in the situation where I prefer to remove a port forward directly on the page where it is created instead of going to the portforawards view

@derailed
Copy link
Owner

derailed commented Aug 4, 2021

@kandros Thank you for this PR! At first glance the code looks good but I am a tad thorn with the behavior ie the original impetus is to create a port-forward and not delete it which will be the optional behavior from this PR if a pf is already present. I understand deleting a pf does require an extra key press but also does give you the ability to delete other pfs in that swoop. Leaving to the good folks here to upvote as I am on the fence on this deal...

@ludusrusso-rc
Copy link

@derailed I'm also interested in this feature but I get your point. What do you think to have a different key mapping for deleting port forwards? something like ctrl-shift-P to delete a pf?

@derailed
Copy link
Owner

derailed commented Aug 5, 2021

@ludusrusso-rc Thank you for your reply! I thought about it a bit and let me float an idea what if we renamed the action `Toggle PortForward' thus if a pf does not exist offer a dialog to create it or if there is a pf offer a dialog to delete it thus no need to nav to the pf view to delete it or intro a new shortcut. What do you guys think?

@BernhardGruen
Copy link

@derailed I quite like your idea. One thing to consider is if it would be still possible to handle multiple port forwards - and adding additional port forwards to existing ones or deleting only some existing port forwards.
Maybe the behavior could be to always delete the existing ones, use them as a base for the new create action and if you close without saving you toggled the port forwards off.

@derailed derailed added enhancement New feature or request needs-tlc Pr needs additional updates needs-review PR needs to be reviewed labels Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-review PR needs to be reviewed needs-tlc Pr needs additional updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants