Support create configmap, secret, deployment, statefulset, namespace, pod #1492
+498
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosone
changed the title
|
@derailed gently ping. Is create resources with k9s in your roadmap? if not, I can close this pr. |
fsniper
reviewed
Nov 10, 2022
| return nil, fmt.Errorf("Expecting *appsv1.Deployment but got %T", obj) | ||
| } | ||
|
|
||
| auth, err := d.Client().CanI(ns, "apps/v1/deployments:create", []string{client.CreateVerb}) |
There was a problem hiding this comment.
Isn't it better to try creating the resource and report auth errors in case? This adds an extra - unnecessary - api call to CanI.
derailed
added
enhancement
|
I will update pr and resolve the conflict. |
tosone
force-pushed
the
feat/create-pod
branch
from
c493921 to
006b9be
Compare
tosone
force-pushed
the
feat/create-pod
branch
from
006b9be to
7a6d4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I implement k9s create resource, could u please review this pr @derailed?