Added plugin to download full container logs #2221
Conversation
| @@ -53,3 +53,13 @@ plugin: | |||
| - $NAMESPACE | |||
| - --context | |||
| - $CONTEXT | |||
| download-container-logs: | |||
| shortCut: Ctrl-D | |||
| description: "download full log" | |||
There was a problem hiding this comment.
I think it would be good to indicate to the users where the logs will be downloaded.
| background: true | ||
| args: | ||
| - -c | ||
| - "kubectl logs -n $NAMESPACE $POD -c $NAME --context $CONTEXT > $POD.log" |
There was a problem hiding this comment.
Do we want the download to land in the cwd?
There was a problem hiding this comment.
yes it will download to current working directory, or i can change it to $HOME ?
There was a problem hiding this comment.
log files have the potential to be sizeable and possibly ephemeral, wondering if parking them in tmp might be a better solution?
There was a problem hiding this comment.
Perhaps add a config setting so the user can define where logs should be downloaded to.
$HOME seems like a reasonable default. /tmp can be very small on security hardend systems.
If size is an issue, compress it on the fly.
derailed
added
question
|
@maabiddevra It looks like there is conflict with the latest drop. Could you update your pr? Thank you! |
Added a new plugin command to download full container logs to local, it is useful when logs are very large after downloading can check the logs easily on local.
Command shortcut:- Ctrl-D