-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Namespace viewer for OpenShift Projects in registrar #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Namespace viewer for OpenShift Projects in registrar #2265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zkck Thank you for your kind words Zak!
I am not super versed in Openshift.
From what I know projects are like k8s ns with extra annotations??
Is this correct?
My concern here is if reusing ns views for this could yield headaches further down stream...
Hi @derailed Thanks for your review! OpenShift Projects are explained as an "alternate representation for a Kubernetes namespace", and is used in OpenShift to isolate members into different collaboration groups. When you create a Project in OpenShift, a Namespace then exists with the same name as the Project. The reason for my PR is because people working in OpenShift do not generally have access to list Namespaces across the cluster, but they have the permissions to list Projects, which lists the Projects that the user has access to. So switching Projects is tedious, since setting the Project requires leaving k9s, listing/setting the Project with the OpenShift CLI ( In terms of whether or not this would cause issues down the line, IMO the fact that a Project is just OpenShift's abstraction of Namespaces and that they both share the exact same resource name gives us a lot of guarantees. Another link: https://docs.openshift.com/container-platform/4.14/applications/projects/working-with-projects.html |
I have 2 openshift clusters, I can test this pull request. |
Thanks @slimus 😄 Just a quick note, I tested this locally with OpenShift Local, and for me |
Hi @zkck thanks for the PR. |
Also very interested in this feature, this would be a great time saver... |
@derailed any change to get this one reviewed and merged? |
14d1126
to
b49a876
Compare
b49a876
to
2f50c51
Compare
@derailed Can you please merge this? |
Closes #2224
Adding OpenShift Projects to the registrar, so that its view behaves like Namespaces. This great codebase made this easy, thanks for this great tool!