Skips loadDir(child) if user has no permissions on parent, or parent does not exist. #3397
Conversation
| @@ -73,6 +73,23 @@ func (p Plugins) Load(path string, loadExtra bool) error { | |||
| // Load from XDG dirs | |||
| const k9sPluginsDir = "k9s/plugins" | |||
| for _, dir := range append(xdg.DataDirs, xdg.DataHome, xdg.ConfigHome) { | |||
| // Try to access the XDG directory. If it's not accessible, either because | |||
There was a problem hiding this comment.
I think this only solves the issue at the top level but what if we have a/b/c where user has rights to a but not b?
Perhaps best to add a helper to check existence and rights during the recursive descent and catch all potential issues?
There was a problem hiding this comment.
I considered this myself, and can definitely write a helper function to be more robust, but figured I'd send the smallest fix first.
I limited it to the top level only to prevent XDG-related (i.e., not k9s-related) errors since the issue suggested the user had no idea or intention of storing k9s files there. If they really did want to store k9s files there, I think the right fix would be for them to fix their permissions.
If the user had /xdg/k9s (with XDG_DATA_DIRS=/xdg) and they had access to /xdg but not /xdg/k9s, they'd get the normal error message - but it would be ignored if k9s is missing (current loadDirs functionality) or the user didn't have permissions to /xdg itself (new).
derailed
added
bug
|
This PR is stale because it has been open for 30 days with no activity. |
This suppresses a potentially-confusing error (#3241) when the k9s user doesn't have access to one of the
XDG_DATA_DIRS.The current behavior attempts to look for
k9s/pluginsinside each directory inXDG_DATA_DIRSand reports apermission deniederror on a non-existent subdirectory because the user has no permission to open the parent.This fix opens the parent directory first and simply logs a warning if there's an issue, avoiding the failed
loadDir(child)call andLoading plugins failed!error when we expect it to fail because of issues with the parent.