feat(prompt): allow custom override for command prompt and filter prompt #3399
Conversation
There was a problem hiding this comment.
@martinblascop I think this make sense.
We do currently use a different border color to differentiate between cmd vs filter modes.
That said I am not sure this warrants the extra configs? Since we could just change the default behavior to use '>' or '/' to be the defaults icons supported or not.
Would this make sense?
README.md
Outdated
| @@ -431,6 +431,10 @@ You can now override the context portForward default address configuration by se | |||
| logoless: false | |||
| # Set to true to hide K9s crumbs. Default false | |||
| crumbsless: false | |||
| # Set custom prompt in command mode. Default to '>' | |||
There was a problem hiding this comment.
nit: perhaps best to use commandPromptPrefix ...
internal/ui/prompt.go
Outdated
| //nolint:exhaustive | ||
| switch k { | ||
| case model.CommandBuffer: | ||
| return userCustomSymbolPrompt(p.app.Config.K9s.GetCommandPromptSymbol()) |
There was a problem hiding this comment.
I think it might be best to keep prompt configuration all in the configuration.
Thus p.app.Config.K9s.GetPromptPrefix will return either the default prefix or the customized one vs having the prompt figure this out.
Would this make better sense?
martinblascop
force-pushed
the
custom-prompt-symbol
branch
from
60b725c to
44fad2f
Compare
I'd love to have |
|
@derailed I think I have addressed your suggestions, is there something missing? |
For terminals that support emojis, you can have different emojis from command mode and filter mode, giving you a hint in which mode you are, but some terminals do not support emojis.
Add support for custom prompt symbols in command and filter mode, to differentiate them, enhancing a bit the user experience.