Skip to content

fix(table): use the table cursorBgColor to highlight selected unmarked rows #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tyholling
Copy link

@tyholling tyholling commented Jun 21, 2025

In the table, a selected row has foreground: cursorFgColor and the background is the normal foreground color for the line. Updating the logic to use the cursorBgColor for selected, unmarked rows.

  • tested by setting cursorBgColor: green in the stock skin
  • added fields to SelectTable for the markColor, the unselected fgColor and bgColor, and the lastSelectedRow, to allow selectionChanged to update the unselected row
  • removed SetSelectedStyle call from ToggleMark, I think it is not needed with this change
  • changed the buildRow SetReference call to every column, to prevent a delay in updating unselected cells after the first column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant