Fix #3422 - ns cmd keep kind #3441
Conversation
| ns, ok := p.NSArg() | ||
| if !ok { | ||
| return false | ||
| } | ||
|
|
||
| if ns != "" { | ||
| _ = p.Reset("pod " + ns) | ||
| currentCommand, ok := c.app.cmdHistory.Top() |
There was a problem hiding this comment.
I think this code has multiple issues ;(
If the last command is :sec fred we will end up with sec fred blee."
This is going to impact the command history i.e if we switch ns A->B any commands in the history buffer that does not explicitly specify a namespace will change. So if a user has po|cm|sec in her buffer that were issued prior to the switch, going back in history will now run all these in ns B vs A. Which is likely not going to be what the user expects. Same argument applies when switching context i.e do we preserve the history or axe it. A blessing and a curse... when going from dev->prod but likely not when going to a completely different cluster.
Perhaps a config option wipeHistoryOnContextSwitch might come in handy?
Looking for feedback/ideas here if anyone else wants to pipe in...
derailed
added
question
No description provided.