Add package.json exports for derby/dist/{components,parsing,templates,test-utils} for compat with TS classic moduleResolution #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…,test-utils} for compat with TS classic moduleResolution Some modules in derby, like test-utils, are not accessible from the root package export. TypeScript with the default classic moduleResolution (pre "node16") doesn't use the package.json exports field, so the only way to use such modules is by using the dist paths, e.g. 'derby/dist/test-utils' instead of the exports-mapped 'derby/test-utils'. This adds package.json exports dist/* paths for a selection of such modules that are useful in consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules in derby, like test-utils, are not accessible from the root package export. TypeScript with the default classic moduleResolution (pre
"node16") doesn't use the package.jsonexportsfield, so the only way to use such modules is by using thedistpaths, e.g.'derby/dist/test-utils'instead of the exports-mapped'derby/test-utils'.This adds package.json
exportsdist/*paths for a selection of such modules that are useful in consumers.