Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RenderOptions optional #633

Merged
merged 2 commits into from
May 15, 2024
Merged

Make RenderOptions optional #633

merged 2 commits into from
May 15, 2024

Conversation

craigbeck
Copy link
Contributor

Fixes ComponentHarness methods renderHtml and renderDom not having optional options argument

Additionally renderHtml and renderDom both returned PageForHarness which left relevant html or fragment attributes as nullable. This adds return types for each method with appropriate non-null attribure (e.g. html: string for renderHtml)

@craigbeck craigbeck requested a review from ericyhwang May 15, 2024 19:22
@craigbeck craigbeck merged commit 6c636f0 into master May 15, 2024
5 checks passed
@craigbeck craigbeck deleted the test-render-options branch May 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigbeck @ericyhwang