Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTR add fitvd pipeline step #63

Merged
merged 5 commits into from
Jan 11, 2024
Merged

FTR add fitvd pipeline step #63

merged 5 commits into from
Jan 11, 2024

Conversation

sidneymau
Copy link
Contributor

Add pipeline step to run shredx and fitvd. Note that this addresses #26

Example eastlake config block:

[...]

fitvd:                                                                                                                                                                                                                     
  conda_prefix: "/pscratch/sd/s/smau/conda/des-y6-fitvd-scratch"
  n_jobs: 128 
  det_band: "r" 
  bands: ["g", "r", "i", "z"]

[...]

@sidneymau
Copy link
Contributor Author

The conda environment should contain roughly the following:

name: des-y6-fitvd
channels:
- conda-forge
- default
dependencies:
- des-fitvd
- shredx
- numpy=1.23.5

Note that I found it important for this to be installed in SCRATCH at NERSC to reduce overhead when spawning all of the subprocesses that run the commands here.

@beckermr
Copy link
Collaborator

LGTM! Are you ready to merge this or is there additional testing to do?

@sidneymau
Copy link
Contributor Author

Sorry for the delay. Have now tested this in the context of an end-to-end eastlake config and smoothed out some bugs

@beckermr beckermr merged commit a05c8b6 into main Jan 11, 2024
2 checks passed
@beckermr beckermr deleted the fitvd branch January 11, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants