updates to delete_sources & swarp #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneymau
commented
Jan 11, 2024
| if os.path.isfile(coadd_object_map_file): | ||
| self.logger.debug("removing file %s" % coadd_object_map_file) | ||
| safe_rm(coadd_object_map_file) | ||
|
|
There was a problem hiding this comment.
as far as I know, this isn't needed for anything downstream (and is leftover from srcextractor/true detection processing...?)—assuming safe to delete
There was a problem hiding this comment.
We should run one sim with all of these recent PRs to make sure.
There was a problem hiding this comment.
This wouldn't affect the sim as this is the last step after everything else is done. I think it's just a question of if the BFD folks need this particular file (from what I recall, they only mentioned needing the meds/fitvd stuff)
There was a problem hiding this comment.
Ah yeah we're good to go then.
sidneymau
changed the title
Closed
sidneymau
force-pushed
the
delete_sources-patch
branch
from
4d1c43f
to
f6ced46
Compare
sidneymau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.