-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uneamour patch 8 1 #59
Open
uneamour
wants to merge
18
commits into
designhawg:master
Choose a base branch
from
uneamour:uneamour-patch-8-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing opening and closing curly brackets (see rows 1 and 38) Added missing hyphens (see row 6) Added missing colons (see row 21) Replaced ".element" with "div.feature" (row 35) Added new groupings (see row 12 and 41) Added ".header" before h1 tag (see row 20)
Added Eric Meyers Reset.CSS file to the css-exercise-one repository
Create Reset.CSS file
Added missing opening and closing curly brackets (see rows 1 and 38) Added missing hyphens (see row 6) Added ".header" before h1 tag (see row 20) Added missing colons (see row 21, 27, 36) Added missing semi-colons (see row 27) Added new groupings (see row 12 and 41) Added ".feature, div, and background color" (see rows 43-53)
Updates to .CSS file
Updated the Style.CSS file to now include missing code that resets the margins and padding (see rows 1-19)
Updated Style.CSS file
Removed reference to "div" (see row 38) Removed duplicates of the .feature indicator so that there is only one referenced in the code at the end Removed independent groupings of height and weight indicators and instead add them to the .nav (see row 9 and 10) and .element (see rows 34 and 35) in the code
Third round revision to style.css file
Updated index file to modify the last 3 div in the code
Updates index.css file
Made modifications to the last 3 div classes in the HTML file
Second revision to index.css file
Added reference to the .element to change the color of the last three divs (see rows 38-42)
Fourth round revisions to the Style.CSS file
Added background color to .element grouping (see row 36)
Fifth revision to Style.CSS
Added hex background color under .feature (See row 40). Removed background color after row 35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added background color under .feature (see row 40)